Skip to content

test: replace some combo-box unit tests with snapshot tests - #4055

Merged
vursen merged 4 commits into
masterfrom
test/combo-box/remove-redudant-unit-tests
Jun 17, 2022
Merged

vursen merged 4 commits into
masterfrom
test/combo-box/remove-redudant-unit-tests

Conversation

@vursen

@vursen vursen commented Jun 17, 2022 •

Copy link
Copy Markdown
Contributor

Description

This PR replaces some a11y-related unit tests with snapshot tests.

Type of change

  • Internal

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Base automatically changed from test/re-organize-snapshot-tests to master June 17, 2022 11:25
@vursen
vursen force-pushed the test/combo-box/remove-redudant-unit-tests branch from 8337994 to 9624e9d Compare June 17, 2022 11:39
@vursen
vursen force-pushed the test/combo-box/remove-redudant-unit-tests branch from 9624e9d to 33190c2 Compare June 17, 2022 11:40
@vursen
vursen marked this pull request as ready for review June 17, 2022 11:40
@vursen
vursen requested a review from web-padawan June 17, 2022 11:40
@vursen vursen changed the title test: replace some unit tests with snapshot tests test: replace some combo-box unit tests with snapshot tests Jun 17, 2022
@vursen
vursen force-pushed the test/combo-box/remove-redudant-unit-tests branch from 4629d90 to f1b07c0 Compare June 17, 2022 12:01
@vursen
vursen requested a review from web-padawan June 17, 2022 12:01
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vursen
vursen merged commit ddf79a5 into master Jun 17, 2022
@vursen
vursen deleted the test/combo-box/remove-redudant-unit-tests branch June 17, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants