Repository navigation
refactor!: remove the default value for step - #4095
Merged
Merged
Conversation
7 tasks done
vursen
force-pushed
the
refactor/remove-default-value-for-step
branch
2 times, most recently
from
June 28, 2022 06:59
a420b80 to
b598277
Compare
vursen
commented
Jun 28, 2022
vursen
marked this pull request as ready for review
June 28, 2022 09:35
vursen
force-pushed
the
refactor/remove-default-value-for-step
branch
from
June 28, 2022 09:52
c959184 to
92c300b
Compare
vursen
force-pushed
the
refactor/remove-default-value-for-step
branch
from
June 28, 2022 09:54
92c300b to
2b2b64e
Compare
vursen
force-pushed
the
refactor/remove-default-value-for-step
branch
from
June 28, 2022 09:57
1616307 to
8b86abe
Compare
web-padawan
reviewed
Jul 4, 2022
web-padawan
left a comment
Member
There was a problem hiding this comment.
Let's remember to update corresponding ITs in the Flow components:
Also, the logic that uses 1 as a fallback step value needs to be replicated in the Flow component, see for example how it's implemented in the TimePicker.
web-padawan
reviewed
Jul 4, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
Author
I checked on the Flow counterpart and looks like its step already defaults to ...so only tests will need to be updated. I'll take care of them during the next release. |
web-padawan
approved these changes
Jul 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
This PR removes the default value for the
stepproperty ofnumber-fieldwhich makes it possible to throw away the custom validation logic entirely relying on theInputConstraintsMixinvalidation logic instead.Breaking changes:
stepproperty no longer has a default value and thereforeundefinedandnullvalues are now allowed.stepproperty no longer leads to setting thestepattribute on thenumber-fieldhost.Related to #1224
Type of change
Checklist