Repository navigation
feat: add theme variants to avatar group material styles - #4106
Conversation
web-padawan
left a comment
There was a problem hiding this comment.
Please add visual tests for all the new variants, similar to those that we have in Lumo:
web-components/packages/avatar/test/visual/lumo/avatar.test.js
Lines 40 to 43 in f922878
web-padawan
left a comment
There was a problem hiding this comment.
This PR adds theme variants to vaadin-avatar-group but not to the vaadin-avatar itself.
@jouni Is this something we would like to provide? If so, it makes sense to update the PR.
|
Yeah, I think it would make sense to keep things consistent and have the same size variants for single avatars as well. |
9bf9131 to
6522d01
Compare
web-padawan
left a comment
There was a problem hiding this comment.
Created #4127 to exclude changes to Lumo visual tests from this PR, as they are not related to Material.
Add theme variants to avatar group Material styles
Add visual tests for both Lumo and Material themes, and both for avatar and avatar group.
6522d01 to
e5bacd7
Compare
e5bacd7 to
ec60518
Compare
|
Kudos, SonarCloud Quality Gate passed!
|








Description
Add theme variants to avatar group Material styles, similar to the ones in the Lumo version.
Related to #1985
Also related to the pull request #4058
Type of change
Checklist