Skip to content

feat: add theme variants to avatar group material styles - #4106

Merged
web-padawan merged 3 commits into
masterfrom
1985-add-theme-variants-to-avatar-group-material
Jul 4, 2022
Merged

web-padawan merged 3 commits into
masterfrom
1985-add-theme-variants-to-avatar-group-material

Conversation

@ugur-vaadin

Copy link
Copy Markdown
Contributor

Description

Add theme variants to avatar group Material styles, similar to the ones in the Lumo version.

Related to #1985
Also related to the pull request #4058

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.
  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@ugur-vaadin
ugur-vaadin requested a review from web-padawan June 29, 2022 08:41

@web-padawan web-padawan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add visual tests for all the new variants, similar to those that we have in Lumo:

it('theme-xlarge', async () => {
element.setAttribute('theme', 'xlarge');
await visualDiff(div, 'theme-xlarge');
});

@web-padawan web-padawan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds theme variants to vaadin-avatar-group but not to the vaadin-avatar itself.
@jouni Is this something we would like to provide? If so, it makes sense to update the PR.

@jouni

jouni commented Jun 29, 2022

Copy link
Copy Markdown
Member

Yeah, I think it would make sense to keep things consistent and have the same size variants for single avatars as well.

@web-padawan
web-padawan force-pushed the 1985-add-theme-variants-to-avatar-group-material branch from 9bf9131 to 6522d01 Compare July 4, 2022 08:57

@web-padawan web-padawan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #4127 to exclude changes to Lumo visual tests from this PR, as they are not related to Material.

Add theme variants to avatar group Material styles
Add visual tests for both Lumo and Material themes, and both for avatar and avatar group.
@web-padawan
web-padawan force-pushed the 1985-add-theme-variants-to-avatar-group-material branch from 6522d01 to e5bacd7 Compare July 4, 2022 10:03
@web-padawan
web-padawan force-pushed the 1985-add-theme-variants-to-avatar-group-material branch from e5bacd7 to ec60518 Compare July 4, 2022 10:19
@sonarqubecloud

sonarqubecloud Bot commented Jul 4, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
web-padawan removed the request for review from jouni July 4, 2022 10:23
@web-padawan
web-padawan merged commit 4b28189 into master Jul 4, 2022
@web-padawan
web-padawan deleted the 1985-add-theme-variants-to-avatar-group-material branch July 4, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants