Skip to content

test: replace some unit tests with snapshot tests - #4118

Merged
web-padawan merged 1 commit into
masterfrom
test/custom-field/replace-unit-tests-with-snapshot-tests
Jul 1, 2022
Merged

web-padawan merged 1 commit into
masterfrom
test/custom-field/replace-unit-tests-with-snapshot-tests

Conversation

@vursen

@vursen vursen commented Jul 1, 2022

Copy link
Copy Markdown
Contributor

Description

This PR replaces some custom-field unit tests with snapshot tests.

Type of change

  • Internal

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@vursen
vursen force-pushed the test/custom-field/replace-unit-tests-with-snapshot-tests branch from 12ebf81 to be05b94 Compare July 1, 2022 08:42
@vursen
vursen force-pushed the test/custom-field/replace-unit-tests-with-snapshot-tests branch from be05b94 to 996e297 Compare July 1, 2022 08:43
@vursen
vursen requested a review from web-padawan July 1, 2022 08:43
@sonarqubecloud

sonarqubecloud Bot commented Jul 1, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
web-padawan merged commit 86800e4 into master Jul 1, 2022
@web-padawan
web-padawan deleted the test/custom-field/replace-unit-tests-with-snapshot-tests branch July 1, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants