Skip to content

fix: clear selection when using clear() method - #4140

Merged
web-padawan merged 2 commits into
masterfrom
fix/msc-clear-method
Jul 8, 2022
Merged

web-padawan merged 2 commits into
masterfrom
fix/msc-clear-method

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

The clear() method in vaadin-multi-select-combo-box is inherited from InputControlMixin and not overridden.
Its current behavior is quite confusing: when the MSC has items selected, calling clear() does nothing.

Let's update the logic and override this method to make it work same as in regular vaadin-combo-box.

Type of change

  • Bugfix

@sonarqubecloud

sonarqubecloud Bot commented Jul 8, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
web-padawan merged commit c4eb6bb into master Jul 8, 2022
@web-padawan
web-padawan deleted the fix/msc-clear-method branch July 8, 2022 08:04
web-padawan added a commit that referenced this pull request Jul 8, 2022
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants