Skip to content

fix: prevent initial validation when checkbox-group is initialized as invalid - #4153

Merged
web-padawan merged 1 commit into
masterfrom
fix/checkbox-group/prevent-initial-validation
Jul 8, 2022
Merged

web-padawan merged 1 commit into
masterfrom
fix/checkbox-group/prevent-initial-validation

Conversation

@vursen

@vursen vursen commented Jul 8, 2022 •

Copy link
Copy Markdown
Contributor

Description

The PR prevents the initial validation that could previously take place when checkbox-group is initially provided with a non-empty value and is initially marked invalid.

Part of #4150

Type of change

  • Bugfix

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@sonarqubecloud

sonarqubecloud Bot commented Jul 8, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DiegoCardoso DiegoCardoso left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants