Repository navigation
test: drop redundant radio-group unit tests - #4205
Merged
Merged
Conversation
web-padawan
approved these changes
Jul 14, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
Member
|
Some of the removed unit tests still serve a purpose. For example, the ones added with #2759 are nowadays testing some parts of If I remove this line or this line, the mentioned tests break, but in both cases the snapshot tests pass. EDIT: Ah, the lines were actually tested by unit tests, but in field-base package (as they should be). Nevermind then. |
Member
|
@tomivirkki Good point, thanks. I think we should restore or adjust those tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
This PR drops some radio-group unit tests that have been replaced with snapshot tests.
A follow-up to #4202
Type of change
Checklist