Skip to content

test: drop redundant radio-group unit tests - #4205

Merged
web-padawan merged 1 commit into
masterfrom
test/radio-group/remove-redundant-tests
Jul 14, 2022
Merged

web-padawan merged 1 commit into
masterfrom
test/radio-group/remove-redundant-tests

Conversation

@vursen

@vursen vursen commented Jul 14, 2022 •

Copy link
Copy Markdown
Contributor

Description

This PR drops some radio-group unit tests that have been replaced with snapshot tests.

A follow-up to #4202

Type of change

  • Internal

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vursen vursen changed the title test: clean up radio-group unit tests test: drop redundant radio-group unit tests Jul 14, 2022
@vursen vursen changed the title test: drop redundant radio-group unit tests test: remove redundant radio-group unit tests Jul 14, 2022
@vursen vursen changed the title test: remove redundant radio-group unit tests test: drop redundant radio-group unit tests Jul 14, 2022
@web-padawan
web-padawan merged commit 61d9b86 into master Jul 14, 2022
@web-padawan
web-padawan deleted the test/radio-group/remove-redundant-tests branch July 14, 2022 15:38
@tomivirkki

tomivirkki commented Jul 14, 2022 •

Copy link
Copy Markdown
Member

Some of the removed unit tests still serve a purpose. For example, the ones added with #2759 are nowadays testing some parts of helper-controller.js.

If I remove this line or this line, the mentioned tests break, but in both cases the snapshot tests pass.

EDIT: Ah, the lines were actually tested by unit tests, but in field-base package (as they should be). Nevermind then.

@web-padawan

Copy link
Copy Markdown
Member

@tomivirkki Good point, thanks. I think we should restore or adjust those tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants