Skip to content

refactor: cleanup no longer needed styles - #4250

Merged
web-padawan merged 1 commit into
masterfrom
refactor/cleanup-grid-styles
Jul 21, 2022
Merged

web-padawan merged 1 commit into
masterfrom
refactor/cleanup-grid-styles

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Related to #4241

The font-size CSS property has been added to the vaadin-checkbox Lumo styles in #2746:

So we can now remove these styles from grid to avoid warning when importing grid after the checkbox.

Type of change

  • Refactor

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@web-padawan
web-padawan removed the request for review from vursen July 21, 2022 06:03
@web-padawan
web-padawan merged commit f127548 into master Jul 21, 2022
@web-padawan
web-padawan deleted the refactor/cleanup-grid-styles branch July 21, 2022 06:03
web-padawan added a commit that referenced this pull request Jul 21, 2022
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
web-padawan added a commit that referenced this pull request Jul 21, 2022
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
web-padawan added a commit that referenced this pull request Jul 21, 2022
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants