Repository navigation
refactor: cleanup no longer needed styles - #4250
Merged
Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
tomivirkki
approved these changes
Jul 21, 2022
vaadin-bot
pushed a commit
that referenced
this pull request
Jul 21, 2022
vaadin-bot
pushed a commit
that referenced
this pull request
Jul 21, 2022
vaadin-bot
pushed a commit
that referenced
this pull request
Jul 21, 2022
web-padawan
added a commit
that referenced
this pull request
Jul 21, 2022
web-padawan
added a commit
that referenced
this pull request
Jul 21, 2022
web-padawan
added a commit
that referenced
this pull request
Jul 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
Related to #4241
The font-size CSS property has been added to the
vaadin-checkboxLumo styles in #2746:web-components/packages/checkbox/theme/lumo/vaadin-checkbox-styles.js
Line 14 in 4fb709e
So we can now remove these styles from grid to avoid warning when importing grid after the checkbox.
Type of change