Repository navigation
fix: sync the hasInputValue state on input - #4335
Conversation
2e33dc2 to
f94a70c
Compare
|
Although this PR fixes the claimed issue, I wonder if we should rather investigate why |
|
The web-components/packages/combo-box/src/vaadin-combo-box-mixin.js Lines 775 to 782 in 71104da As follows from the comment, the logic is intended to prevent the form submission but in fact, |
|
Anyway, the current fix is still good enough to solve the original problem on the Flow side. As for the |
a9d7182 to
29c1ef1
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
This ticket/PR has been released with Vaadin 23.2.0.beta1 and is also targeting the upcoming stable 23.2.0 version. |








Description
It turns out that
TimePickerprevents thechangeevent on the input element until it loses focus, so it is possible to commit a non-empty value on Enter but have thehasInputValuestate not updated.This PR makes the
hasInputValuestate update oninputrather thanchangewhich ensureshasInputValueis synced in the above case as well.A follow-up to #4276
Related to vaadin/flow-components#3515
Type of change
Checklist