Skip to content

test: improve validation test coverage - #4363

Merged
web-padawan merged 2 commits into
masterfrom
test/multi-select-combo-box/improve-test-coverage
Aug 18, 2022
Merged

web-padawan merged 2 commits into
masterfrom
test/multi-select-combo-box/improve-test-coverage

Conversation

@vursen

@vursen vursen commented Aug 17, 2022 •

Copy link
Copy Markdown
Contributor

Description

  • Extracted validation tests into a separate file validation.test.js
  • Added tests ensuring no initial validation happens.
  • Added a test ensuring no validation happens on required constraint change. It is needed to ensure #4359 works well for components whose value property has a type other than string or value is represented by other property than value, e.g. selectedItems in multi-select-combo-box.

Type of change

  • Internal

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@vursen
vursen requested a review from web-padawan August 17, 2022 12:47
@vursen
vursen force-pushed the test/multi-select-combo-box/improve-test-coverage branch from 59c4c62 to cfc2b33 Compare August 17, 2022 12:48

@web-padawan web-padawan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add a test suite for initial validation, similar to what we have in other components?

@vursen

vursen commented Aug 17, 2022 •

Copy link
Copy Markdown
Contributor Author

Should we also add a test suite for initial validation, similar to what we have in other components?

Good point, let me add them

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
web-padawan merged commit 6951350 into master Aug 18, 2022
@web-padawan
web-padawan deleted the test/multi-select-combo-box/improve-test-coverage branch August 18, 2022 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants