Skip to content

test: remove redundant unit tests - #4380

Merged
web-padawan merged 1 commit into
masterfrom
test/email-field/remove-redundant-tests
Aug 23, 2022
Merged

web-padawan merged 1 commit into
masterfrom
test/email-field/remove-redundant-tests

Conversation

@vursen

@vursen vursen commented Aug 22, 2022 •

Copy link
Copy Markdown
Contributor

Description

The PR removes some email-field unit tests ensuring the initial invalid is not overridden. These tests are redundant because there is already an initial validation test suite that determines when the initial validation should happen and when not, which in practice also ensures that invalid will not be overridden.

Part of #4371

Type of change

  • Internal

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@vursen
vursen requested a review from tomivirkki August 22, 2022 14:58
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@web-padawan
web-padawan merged commit 9b2b9a2 into master Aug 23, 2022
@web-padawan
web-padawan deleted the test/email-field/remove-redundant-tests branch August 23, 2022 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants