Skip to content

refactor: cleanup overlay content default styles - #4397

Merged
web-padawan merged 1 commit into
masterfrom
refactor/cleanup-content-styles
Aug 31, 2022
Merged

web-padawan merged 1 commit into
masterfrom
refactor/cleanup-content-styles

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Removed some styles that are leftovers from vaadin-date-picker 2.0 version - see example:

Overlay header (uses padding-bottom: 40px):

Screenshot 2022-08-26 at 16 02 39

Year toggle button (uses position: absolute):

Screenshot 2022-08-26 at 16 01 40

These styles are not used in Lumo and Material and require overrides. So I think we can just remove them.

Type of change

  • Refactor

@web-padawan
web-padawan requested a review from jouni August 26, 2022 13:13
@web-padawan
web-padawan force-pushed the refactor/cleanup-content-styles branch from d276baa to e0a1cbe Compare August 26, 2022 13:16
text-align: center;
}

[part='clear-button'],

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I merged two selectors because padding and color for year-toggle-button are specified separately.

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 23.2.0.rc1 and is also targeting the upcoming stable 23.2.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants