Repository navigation
refactor: cleanup overlay content default styles - #4397
Merged
Merged
Conversation
web-padawan
force-pushed
the
refactor/cleanup-content-styles
branch
from
August 26, 2022 13:16
d276baa to
e0a1cbe
Compare
web-padawan
commented
Aug 26, 2022
| text-align: center; | ||
| } | ||
|
|
||
| [part='clear-button'], |
Member
Author
There was a problem hiding this comment.
Here I merged two selectors because padding and color for year-toggle-button are specified separately.
|
Kudos, SonarCloud Quality Gate passed! |
jouni
approved these changes
Aug 31, 2022
Collaborator
|
This ticket/PR has been released with Vaadin 23.2.0.rc1 and is also targeting the upcoming stable 23.2.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
Removed some styles that are leftovers from
vaadin-date-picker2.0 version - see example:Overlay header (uses
padding-bottom: 40px):Year toggle button (uses
position: absolute):These styles are not used in Lumo and Material and require overrides. So I think we can just remove them.
Type of change