Skip to content

refactor!: ensure initial validation with constraints and value - #4422

Merged
web-padawan merged 1 commit into
masterfrom
refactor/date-time-picker/ensure-initial-validation-with-constraints-and-value
Aug 31, 2022
Merged

web-padawan merged 1 commit into
masterfrom
refactor/date-time-picker/ensure-initial-validation-with-constraints-and-value

Conversation

@vursen

@vursen vursen commented Aug 31, 2022 •

Copy link
Copy Markdown
Contributor

Description

This PR ensures initial validation when date-time-picker has constraints and value.

Question: Should it go as a breaking change? It is kind of a breaking change because previously the user could control invalid manually even with constraints which becomes no longer possible.

Extracted from #4386

Part of #4371

Type of change

  • Refactor

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@vursen
vursen requested a review from web-padawan August 31, 2022 09:49
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan web-padawan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Should it go as a breaking change?

I don't think so, its probably enough to use refactor:

@web-padawan
web-padawan merged commit 1cce787 into master Aug 31, 2022
@web-padawan
web-padawan deleted the refactor/date-time-picker/ensure-initial-validation-with-constraints-and-value branch August 31, 2022 09:54
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 23.2.0.rc1 and is also targeting the upcoming stable 23.2.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants