Repository navigation
refactor!: ensure initial validation with constraints and value - #4422
Merged
web-padawan merged 1 commit intoAug 31, 2022
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
web-padawan
approved these changes
Aug 31, 2022
web-padawan
left a comment
Member
There was a problem hiding this comment.
LGTM.
Should it go as a breaking change?
I don't think so, its probably enough to use refactor:
web-padawan
deleted the
refactor/date-time-picker/ensure-initial-validation-with-constraints-and-value
branch
August 31, 2022 09:54
Collaborator
|
This ticket/PR has been released with Vaadin 23.2.0.rc1 and is also targeting the upcoming stable 23.2.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
This PR ensures initial validation when
date-time-pickerhas constraints and value.Question: Should it go as a breaking change? It is kind of a breaking change because previously the user could control
invalidmanually even with constraints which becomes no longer possible.Extracted from #4386
Part of #4371
Type of change
Checklist