Skip to content

feat: add tooltip support to vaadin-button - #4448

Merged
web-padawan merged 1 commit into
masterfrom
feat/button-tooltip
Sep 2, 2022
Merged

web-padawan merged 1 commit into
masterfrom
feat/button-tooltip

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Added vaadin-tooltip support to vaadin-button via tooltip slot and TooltipController.

Note, because of how SlotController works, I had to add tooltip slot to all components that extend Button.
This means that e.g. vaadin-drawer-toggle also gets support for the tooltip, which is probably expected.

Type of change

  • Feature

@sonarqubecloud

sonarqubecloud Bot commented Sep 2, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
web-padawan merged commit 5c88e8c into master Sep 2, 2022
@web-padawan
web-padawan deleted the feat/button-tooltip branch September 2, 2022 09:51
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 23.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants