Skip to content

refactor: cleanup validation methods typings - #4488

Merged
web-padawan merged 3 commits into
masterfrom
refactor/ts-validate-cleanup
Sep 5, 2022
Merged

web-padawan merged 3 commits into
masterfrom
refactor/ts-validate-cleanup

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

There is no need to re-declare validate() and checkValidity() methods as they are declared in ValidateMixin.

Type of change

  • Refactor

@sonarqubecloud

sonarqubecloud Bot commented Sep 5, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
web-padawan merged commit 95d52bd into master Sep 5, 2022
@web-padawan
web-padawan deleted the refactor/ts-validate-cleanup branch September 5, 2022 15:26
@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @web-padawan , this commit cannot be picked to 23.2 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick 95d52bd
error: could not apply 95d52bd... refactor: cleanup validation methods typings (#4488)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants