Skip to content

fix: do not reopen overlay when moving focus within target - #4528

Merged
web-padawan merged 4 commits into
masterfrom
fix/tooltip-focus-esc
Sep 7, 2022
Merged

web-padawan merged 4 commits into
masterfrom
fix/tooltip-focus-esc

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Fixes #4524

There are actually two fixes in this PR but these are related:

  1. Changed to not close tooltip on focusout within a field (e.g. vaadin-password-field or vaadin-list-box),
  2. Changed to not re-open tooltip on focusin within a field after pressing Escape to dismiss it.

Type of change

  • Bugfix

Comment thread packages/tooltip/src/vaadin-tooltip.js Resolved
@web-padawan web-padawan changed the title fix: do not reopen overlay after Esc while focused fix: do not reopen overlay when moving focus within target Sep 7, 2022
@sonarqubecloud

sonarqubecloud Bot commented Sep 7, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
web-padawan merged commit 8303b86 into master Sep 7, 2022
@web-padawan
web-padawan deleted the fix/tooltip-focus-esc branch September 7, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[tooltip] When closed on Esc, tooltip is re-opened on focusin within a field

2 participants