Skip to content

fix: do not close on mouseleave to tooltip overlay - #4596

Merged
web-padawan merged 1 commit into
masterfrom
fix/overlay-mouseleave
Sep 14, 2022
Merged

web-padawan merged 1 commit into
masterfrom
fix/overlay-mouseleave

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

This PR addresses the issue discovered in #4591 (comment).

In some conditions, when overlay is open immediately (zero hover delay), the mouseenter event is immediately followed by mouseleave event because cursor moves to vaadin-tooltip-overlay which causes it to close.

Added logic to prevent mouseleave to overlay (and then back to target) from closing the tooltip.
This also allows users to e.g. select the text shown in the tooltip and copy it to clipboard.

Finally, this change makes the tooltip satisfy the WCAG Criterion 1.14.13:

If pointer hover can trigger the additional content, then the pointer can be moved over the additional content without the additional content disappearing.

Type of change

  • Bugfix

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 23.3.0.alpha1 and is also targeting the upcoming stable 23.3.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants