Skip to content

refactor: remove obsolete overlay positioning logic from menu bar - #4637

Merged
sissbruecker merged 1 commit into
masterfrom
refactor/remove_legacy_position_logic
Sep 26, 2022
Merged

sissbruecker merged 1 commit into
masterfrom
refactor/remove_legacy_position_logic

Conversation

@sissbruecker

Copy link
Copy Markdown
Member

Description

Removes obsolete end-aligned / bottom-aligned positioning logic from menu bar. Since the refactoring to use position mixin this method seems unnecessary and actually creates an unintended offset from the position target that is later cleaned up by a delayed repositioning of the position mixin:

Bildschirmaufnahme.2022-09-26.um.14.42.38.mov

Similar behavior when using bottom-aligned:

Bildschirmfoto 2022-09-26 um 14 50 57

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@web-padawan web-padawan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Tested manually and it works as expected.

@sissbruecker
sissbruecker merged commit b54d075 into master Sep 26, 2022
@sissbruecker
sissbruecker deleted the refactor/remove_legacy_position_logic branch September 26, 2022 13:18
web-padawan pushed a commit that referenced this pull request Sep 26, 2022
Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
web-padawan pushed a commit that referenced this pull request Sep 26, 2022
Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants