Repository navigation
refactor: remove obsolete overlay positioning logic from menu bar - #4637
Merged
Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
web-padawan
approved these changes
Sep 26, 2022
web-padawan
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks. Tested manually and it works as expected.
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 26, 2022
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 26, 2022
web-padawan
pushed a commit
that referenced
this pull request
Sep 26, 2022
web-padawan
pushed a commit
that referenced
this pull request
Sep 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
Removes obsolete end-aligned / bottom-aligned positioning logic from menu bar. Since the refactoring to use position mixin this method seems unnecessary and actually creates an unintended offset from the position target that is later cleaned up by a delayed repositioning of the position mixin:
Bildschirmaufnahme.2022-09-26.um.14.42.38.mov
Similar behavior when using bottom-aligned: