Skip to content

fix: escape regex operators in upload accept pattern - #4641

Merged
sissbruecker merged 1 commit into
masterfrom
fix/upload_escape_accept_string
Sep 28, 2022
Merged

sissbruecker merged 1 commit into
masterfrom
fix/upload_escape_accept_string

Conversation

@sissbruecker

Copy link
Copy Markdown
Member

Description

Fixes the upload accept pattern to escape regex operators that are common in mime types.

Fixes #4372

Type of change

  • Bugfix

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @sissbruecker , this commit cannot be picked to 22.0 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick 247920e
error: could not apply 247920e... fix: escape regex operators in upload accept pattern (#4641)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

sissbruecker added a commit that referenced this pull request Sep 28, 2022
Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
sissbruecker added a commit that referenced this pull request Sep 28, 2022
Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

<vaadin-upload> accept regex failure when mimetype contains '+'

3 participants