Skip to content

fix: hide weekdays from assistive technologies - #4658

Merged
web-padawan merged 3 commits into
masterfrom
feat/date-picker/add-aria-hidden
Oct 3, 2022
Merged

web-padawan merged 3 commits into
masterfrom
feat/date-picker/add-aria-hidden

Conversation

@vursen

@vursen vursen commented Oct 2, 2022 •

Copy link
Copy Markdown
Contributor

Description

This PR adds aria-hidden to the cells representing weekdays in order to hide them from assistive technologies as recommended by Tetralogical.

Fixes #4313

Type of change

  • Bugfix

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/overview
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@vursen
vursen marked this pull request as ready for review October 2, 2022 17:28
@vursen vursen changed the title fix: hide week days from assistive technologies fix: hide weekdays from assistive technologies Oct 2, 2022
@sonarqubecloud

sonarqubecloud Bot commented Oct 2, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
web-padawan merged commit d114ce7 into master Oct 3, 2022
@web-padawan
web-padawan deleted the feat/date-picker/add-aria-hidden branch October 3, 2022 07:04
@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @vursen , this commit cannot be picked to 23.1 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick d114ce7
error: could not apply d114ce7... fix: hide weekdays from assistive technologies (#4658)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

web-padawan pushed a commit that referenced this pull request Oct 3, 2022
Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DatePicker calendar: Hide weekdays from assistive technologies

3 participants