Skip to content

feat: publish icon assets to npm - #4675

Merged
web-padawan merged 2 commits into
masterfrom
fix/publish-assets-to-npm
Oct 4, 2022
Merged

web-padawan merged 2 commits into
masterfrom
fix/publish-assets-to-npm

Conversation

@vursen

@vursen vursen commented Oct 4, 2022

Copy link
Copy Markdown
Contributor

Description

The PR adds a assets/**/* glob to package.json to get icon assets published to npm along with other source files.

Fixes #1624

Type of change

  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/overview
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@vursen
vursen requested a review from web-padawan October 4, 2022 09:42
@vursen
vursen marked this pull request as ready for review October 4, 2022 09:42
@sonarqubecloud

sonarqubecloud Bot commented Oct 4, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
web-padawan merged commit c2041df into master Oct 4, 2022
@web-padawan
web-padawan deleted the fix/publish-assets-to-npm branch October 4, 2022 10:30
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 23.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publish assets/vaadin-font-icons.json to npm

3 participants