Skip to content

refactor: extract opened state logic to controller - #4676

Merged
web-padawan merged 1 commit into
masterfrom
refactor/tooltip-state
Oct 4, 2022
Merged

web-padawan merged 1 commit into
masterfrom
refactor/tooltip-state

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Related to #4640

Extracted some logic related to opening / closing a tooltip to the dedicated TooltipStateController.

The idea behind this change is to call open() and close() methods when using manual tooltip.
This would enable an opt-in delays support, without explicitly enabling them for manual mode.

Note: there will be separate PRs for vaadin-grid and vaadin-menu-bar based on this one.

Type of change

  • Refactor

@web-padawan
web-padawan requested a review from tomivirkki October 4, 2022 12:31
@sonarqubecloud

sonarqubecloud Bot commented Oct 4, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants