Skip to content

docs: show a warning when auto-freezing joined grid columns - #4680

Merged
web-padawan merged 3 commits into
masterfrom
docs/warn-auto-freezing-columns
Oct 6, 2022
Merged

web-padawan merged 3 commits into
masterfrom
docs/warn-auto-freezing-columns

Conversation

@tomivirkki

Copy link
Copy Markdown
Member

The PR makes <vaadin-grid> show a warning when frozen and non-frozen columns are grouped together inside a single column group.

For example:

<vaadin-grid-column-group>
  <vaadin-grid-column frozen></vaadin-grid-column>
  <vaadin-grid-column></vaadin-grid-column>
</vaadin-grid-column-group>

When this happens, the column group will automatically also freeze the non-frozen column to avoid rendering glitches.

Sometimes, joining frozen and non-frozen columns may happen unintentionally, especially in Flow applications. The warning advises the developer to either mark all the joined columns explicitly as frozen, or to exclude the frozen ones from the set of columns being joined.

Related to vaadin/flow-components#3363

@tomivirkki
tomivirkki requested a review from web-padawan October 5, 2022 11:29
@sonarqubecloud

sonarqubecloud Bot commented Oct 5, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
web-padawan merged commit 619051e into master Oct 6, 2022
@web-padawan
web-padawan deleted the docs/warn-auto-freezing-columns branch October 6, 2022 07:00
@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @tomivirkki , this commit cannot be picked to 23.1 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick 619051e
error: could not apply 619051e... docs: show a warning when auto-freezing joined columns (#4680)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants