Skip to content

fix: ensure variable item height virtualizer scrolls to top - #4703

Merged
web-padawan merged 1 commit into
masterfrom
fix/virtualizer-scroll-zero-index
Oct 10, 2022
Merged

web-padawan merged 1 commit into
masterfrom
fix/virtualizer-scroll-zero-index

Conversation

@tomivirkki

Copy link
Copy Markdown
Member

Fixes #4659

The root problem is somewhere in the iron-list scrolling logic and the problem can be reproduced with <iron-list> alone:

iron-list-scroll-to-top-issue.mp4

Since we don't want to modify the iron-list core, it's better to work around the issue in the adapter instead.

@tomivirkki
tomivirkki requested a review from vursen October 7, 2022 12:43
@sonarqubecloud

sonarqubecloud Bot commented Oct 7, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
web-padawan removed the request for review from vursen October 10, 2022 06:16
@web-padawan
web-padawan merged commit 9ca62ab into master Oct 10, 2022
@web-padawan
web-padawan deleted the fix/virtualizer-scroll-zero-index branch October 10, 2022 06:16
web-padawan pushed a commit that referenced this pull request Oct 10, 2022
…4705)

Co-authored-by: Tomi Virkki <tomivirkki@users.noreply.github.com>
web-padawan pushed a commit that referenced this pull request Oct 10, 2022
…4706)

Co-authored-by: Tomi Virkki <tomivirkki@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[combo-box] Some items may be missing after fast scrolling to the top [2 days]

3 participants