Skip to content

fix: add missing Lumo and Material dependencies - #4728

Merged
web-padawan merged 1 commit into
masterfrom
fix/charts-theme-deps
Oct 13, 2022
Merged

web-padawan merged 1 commit into
masterfrom
fix/charts-theme-deps

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

We missed to add Lumo and Material dependencies to @vaadin/charts when implementing themes. This PR fixes it.

Type of change

  • Bugfix

Note

This issue was discovered when trying to use pnpm instead of yarn as it fails to resolve these imports.

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants