Skip to content

chore: add imported packages to direct dependencies - #4731

Merged
web-padawan merged 1 commit into
masterfrom
chore/password-field-deps
Oct 13, 2022
Merged

web-padawan merged 1 commit into
masterfrom
chore/password-field-deps

Conversation

@web-padawan

@web-padawan web-padawan commented Oct 13, 2022 •

Copy link
Copy Markdown
Member

Description

Currently, @vaadin/password-field package imports some transitive dependencies coming from @vaadin/text-field.
This PR adds @vaadin/component-base and @vaadin/vaadin-themable-mixin as direct dependencies.

Type of change

  • Internal change

Note

This issue was discovered when trying to use pnpm instead of yarn as it fails to resolve these imports.

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
web-padawan merged commit 8503d2c into master Oct 13, 2022
@web-padawan
web-padawan deleted the chore/password-field-deps branch October 13, 2022 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants