Skip to content

refactor: small code style tweaks, add missing JSDoc - #4777

Merged
web-padawan merged 4 commits into
masterfrom
refactor/dp-small-tweaks
Oct 19, 2022
Merged

web-padawan merged 4 commits into
masterfrom
refactor/dp-small-tweaks

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Some small updates to date-picker and infinite-scroller extracted from #4770:

  1. Replaced ES5 leftovers [].forEach.call and Array.prototype.slice.call with array spread,
  2. Replaced legacy Polymer-specific root property coming from Polymer 1 era with shadowRoot,
  3. Changed wording to use slot instead of insertionPoint (which was a Polymer 1 equivalent),
  4. Removed mention of iron-media-query from CSS comment (we now use a different approach),
  5. Added missing JSDoc annotations to all vaadin-infinite-scroller properties and methods.

Type of change

  • Refactor

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @web-padawan , this commit cannot be picked to 23.1 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick 834683c
error: could not apply 834683c... refactor: small code style tweaks, add missing JSDoc (#4777)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

web-padawan added a commit that referenced this pull request Oct 19, 2022
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
web-padawan added a commit that referenced this pull request Oct 19, 2022
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants