Skip to content

test: use onceInvoked helper in ResizeMixin tests - #4853

Merged
web-padawan merged 1 commit into
masterfrom
test/resize-mixin
Oct 27, 2022
Merged

web-padawan merged 1 commit into
masterfrom
test/resize-mixin

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Updated ResizeMixin tests to use onceInvoked helper that we generally use to wait for resize observer.
This change aims to stabilize some of these tests that became flaky with the latest Playwright WebKit:

packages/component-base/test/resize-mixin.test.js:

 ❌ resize-mixin > observe parent > light DOM > should notify parent element resize
      Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.
        at createTimeoutError (node_modules/@web/test-runner-mocha/dist/autorun.js:1:243204)
        at node_modules/@web/test-runner-mocha/dist/autorun.js:1:257230

 ❌ resize-mixin > observe parent > shadow DOM > should notify shadow host resize
      Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.
        at createTimeoutError (node_modules/@web/test-runner-mocha/dist/autorun.js:1:243204)
        at node_modules/@web/test-runner-mocha/dist/autorun.js:1:257230

Type of change

  • Tests

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
web-padawan merged commit 0451e27 into master Oct 27, 2022
@web-padawan
web-padawan deleted the test/resize-mixin branch October 27, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants