Repository navigation
refactor!: move button and drop label to light DOM - #4857
Merged
Merged
Conversation
web-padawan
commented
Oct 27, 2022
Comment on lines
-27
to
-30
| [part='primary-buttons'] > * { | ||
| display: inline-block; | ||
| white-space: nowrap; | ||
| } |
Member
Author
There was a problem hiding this comment.
These styles don't seem to be needed anymore, because the vaadin-button already has them built-in:
web-components/packages/button/src/vaadin-button.js
Lines 56 to 59 in 090aff7
Comment on lines
-26
to
-30
| /* TODO(jouni): unsupported selector (not sure why there's #addFiles element wrapping the upload button) */ | ||
| [part='primary-buttons'] > * { | ||
| display: block; | ||
| flex-grow: 1; | ||
| } |
Member
Author
There was a problem hiding this comment.
Removing flex-grow: 1 doesn't seem to affect anything, as the container uses display: inline-flex.
|
Kudos, SonarCloud Quality Gate passed!
|
sissbruecker
approved these changes
Oct 28, 2022
Collaborator
|
This ticket/PR has been released with Vaadin 24.0.0. |
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
Fixes #4281
add-button,drop-labelanddrop-label-iconelements to slots usingSlotController,vaadin-upload-iconelement for default upload icon (so that we can apply styles to it),<div id="addFiles">wrapping the button, as it doesn't seem to be needed.Type of change