Skip to content

refactor: add Lit support to input field mixins - #4864

Merged
web-padawan merged 2 commits into
masterfrom
refactor/lit-input-field-mixins
Nov 2, 2022
Merged

web-padawan merged 2 commits into
masterfrom
refactor/lit-input-field-mixins

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

  1. Updated tests for InputControlMixin and InputFieldMixin to run with Polymer and Lit,
  2. Fixed the clear() method to immediately clear <input> value to avoid Lit update issue.

Type of change

  • Refactor

@web-padawan
web-padawan requested a review from vursen October 28, 2022 09:18
@web-padawan
web-padawan force-pushed the refactor/lit-input-field-mixins branch from a6923b0 to fc099c3 Compare October 28, 2022 09:20
@web-padawan
web-padawan force-pushed the refactor/lit-input-field-mixins branch from fc099c3 to 927bf34 Compare October 28, 2022 09:21
Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
@sonarqubecloud

sonarqubecloud Bot commented Nov 2, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
web-padawan removed the request for review from vursen November 2, 2022 09:34
@web-padawan
web-padawan merged commit 7fa5151 into master Nov 2, 2022
@web-padawan
web-padawan deleted the refactor/lit-input-field-mixins branch November 2, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants