Skip to content

refactor!: remove upload file progress bar attributes - #4871

Merged
web-padawan merged 2 commits into
masterfrom
refactor/upload-progress-attr
Nov 2, 2022
Merged

web-padawan merged 2 commits into
masterfrom
refactor/upload-progress-attr

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Extracted from #4870 so that this change could be separately mentioned in the release notes.
Removed attributes from vaadin-progress-bar as they are duplicates of host attributes.

Also, moved corresponding CSS from themes to core styles to avoid duplication.

Type of change

  • Breaking change

@web-padawan
web-padawan removed the request for review from sissbruecker November 2, 2022 07:25
@web-padawan
web-padawan merged commit b73bdc1 into master Nov 2, 2022
@web-padawan
web-padawan deleted the refactor/upload-progress-attr branch November 2, 2022 07:27
@sonarqubecloud

sonarqubecloud Bot commented Nov 2, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants