Repository navigation
refactor: cleanup no longer needed login-form code - #4888
Conversation
| /** @protected */ | ||
| connectedCallback() { | ||
| super.connectedCallback(); | ||
| this._handleInputKeydown = this._handleInputKeydown.bind(this); |
There was a problem hiding this comment.
No need to bind this listener, because it's used in a template and Polymer handles that.
|
|
||
| /** @private */ | ||
| __isValid(input) { | ||
| return (input.validate && input.validate()) || (input.checkValidity && input.checkValidity()); |
There was a problem hiding this comment.
Simplified this logic, as both vaadin-text-field and vaadin-password-field support validate().
|
Kudos, SonarCloud Quality Gate passed!
|
| action="{{action}}" | ||
| disabled="{{disabled}}" | ||
| error="{{error}}" | ||
| no-forgot-password="{{noForgotPassword}}" | ||
| i18n="{{i18n}}" |
There was a problem hiding this comment.
No need to bind action and disabled because the form wrapper doesn't use both properties.
Changed others to use one-way data binding, as they aren't changed in the form wrapper.
|
Hi @web-padawan , this commit cannot be picked to 22.0 by this bot, can you take a look and pick it manually? |








Description
Removed some code that was needed for older browsers, including
event.keyCodeand iOS workaround.Also fixed duplicate line for
error-message-descriptioncontainer in the stylable parts table.Type of change