Repository navigation
refactor!: do not notify properties set from outside - #4905
Merged
Merged
Conversation
web-padawan
force-pushed
the
refactor/remove-notify-true
branch
from
November 3, 2022 13:39
34b98b1 to
3f102af
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
|
It isn't very clear to me, what is the breaking change here if the component doesn't modify these properties internally? Did it use to fire an initial event before? |
Member
Author
|
Yes, the event for an initial value was fired before. I'm not sure if someone was actually using those events, though. |
vursen
approved these changes
Nov 4, 2022
web-padawan
requested review from
vursen
and removed request for
sissbruecker and
vursen
November 4, 2022 07:45
vaadin-bot
pushed a commit
that referenced
this pull request
Nov 4, 2022
web-padawan
added a commit
that referenced
this pull request
Nov 4, 2022
Collaborator
|
This ticket/PR has been released with Vaadin 24.0.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
Related to #4900
Removed
notify: truefrom some properties that are not modified by the component internally:actionnoForgotPasswordi18nThis affects Flow counterpart as we would need to remove
@SynchronizefromgetAction().However, the change is so small that we can probably backport it at least to Vaadin 23.3.
Type of change