Skip to content

refactor!: do not notify properties set from outside - #4905

Merged
web-padawan merged 2 commits into
masterfrom
refactor/remove-notify-true
Nov 4, 2022
Merged

web-padawan merged 2 commits into
masterfrom
refactor/remove-notify-true

Conversation

@web-padawan

@web-padawan web-padawan commented Nov 3, 2022 •

Copy link
Copy Markdown
Member

Description

Related to #4900

Removed notify: true from some properties that are not modified by the component internally:

  • action
  • noForgotPassword
  • i18n

This affects Flow counterpart as we would need to remove @Synchronize from getAction().
However, the change is so small that we can probably backport it at least to Vaadin 23.3.

Type of change

  • Behavior altering change

@web-padawan
web-padawan force-pushed the refactor/remove-notify-true branch from 34b98b1 to 3f102af Compare November 3, 2022 13:39
@sonarqubecloud

sonarqubecloud Bot commented Nov 3, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vursen

vursen commented Nov 3, 2022 •

Copy link
Copy Markdown
Contributor

It isn't very clear to me, what is the breaking change here if the component doesn't modify these properties internally? Did it use to fire an initial event before?

@web-padawan

Copy link
Copy Markdown
Member Author

Yes, the event for an initial value was fired before. I'm not sure if someone was actually using those events, though.

@web-padawan
web-padawan requested review from vursen and removed request for sissbruecker and vursen November 4, 2022 07:45
@web-padawan
web-padawan merged commit ea80b2c into master Nov 4, 2022
@web-padawan
web-padawan deleted the refactor/remove-notify-true branch November 4, 2022 07:45
web-padawan added a commit that referenced this pull request Nov 4, 2022
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants