Skip to content

fix: add missing event map to vaadin-accordion-panel - #4906

Merged
web-padawan merged 1 commit into
masterfrom
fix/accordion-panel-event-map
Nov 4, 2022
Merged

web-padawan merged 1 commit into
masterfrom
fix/accordion-panel-event-map

Conversation

@web-padawan

@web-padawan web-padawan commented Nov 3, 2022 •

Copy link
Copy Markdown
Member

Description

Added missing AccordionPanelEventMap with custom type for opened-changed event.
While this event is inherited from Details, the lack of proper type is a bit inconvenient.

This is different from e.g. vaadin-email-field that extends vaadin-text-field but has own event map:

export interface EmailFieldEventMap extends HTMLElementEventMap, EmailFieldCustomEventMap {

Let's add this event map so that users don't have to import the event type from @vaadin/details.

Type of change

  • Bugfix

@sonarqubecloud

sonarqubecloud Bot commented Nov 3, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
web-padawan requested review from tomivirkki and vursen and removed request for sissbruecker November 3, 2022 13:20
@web-padawan
web-padawan removed the request for review from vursen November 4, 2022 09:51
@web-padawan
web-padawan merged commit 0803d52 into master Nov 4, 2022
@web-padawan
web-padawan deleted the fix/accordion-panel-event-map branch November 4, 2022 09:52
@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @web-padawan , this commit cannot be picked to 23.1 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick 0803d52
error: could not apply 0803d52... fix: add missing event map to vaadin-accordion-panel (#4906)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

web-padawan added a commit that referenced this pull request Nov 4, 2022
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
web-padawan added a commit that referenced this pull request Nov 4, 2022
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants