Skip to content

fix: add missing index property to CrudEditEvent - #4907

Merged
web-padawan merged 1 commit into
masterfrom
fix/crud-edit-event-map
Nov 4, 2022
Merged

web-padawan merged 1 commit into
masterfrom
fix/crud-edit-event-map

Conversation

@web-padawan

@web-padawan web-padawan commented Nov 3, 2022 •

Copy link
Copy Markdown
Member

Description

While we have CrudEditEvent currently on vaadin-crud, in fact it bubbles from the vaadin-crud-edit element.

The index numeric property was missing from the event.detail type of CrudEditEvent, so I added it there.

Type of change

  • Bugfix

@web-padawan

Copy link
Copy Markdown
Member Author

Actually, I just realised that the event is fired on the <tr> element, so this PR can be closed 🙈
Will change it to add missing index parameter to the CrudEditEvent and that's it.

@web-padawan
web-padawan force-pushed the fix/crud-edit-event-map branch from 1b982a2 to 4b72886 Compare November 3, 2022 13:31
@web-padawan web-padawan changed the title fix: add missing event map to vaadin-crud-edit fix: add missing index property to CrudEditEvent Nov 3, 2022
@sonarqubecloud

sonarqubecloud Bot commented Nov 3, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
web-padawan requested review from tomivirkki and removed request for sissbruecker November 4, 2022 08:16
@web-padawan
web-padawan removed the request for review from vursen November 4, 2022 08:42
@web-padawan
web-padawan merged commit 522639c into master Nov 4, 2022
@web-padawan
web-padawan deleted the fix/crud-edit-event-map branch November 4, 2022 08:47
web-padawan added a commit that referenced this pull request Nov 4, 2022
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
web-padawan added a commit that referenced this pull request Nov 4, 2022
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
web-padawan added a commit that referenced this pull request Nov 4, 2022
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants