Skip to content

fix: make notification renderer argument required - #4934

Merged
web-padawan merged 1 commit into
masterfrom
fix/notification-renderer-args
Nov 4, 2022
Merged

web-padawan merged 1 commit into
masterfrom
fix/notification-renderer-args

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Related to #4900

Fixed the NotificationRenderer to apply the same change that we previously made in #2097 for grid renderers.
This addresses the following finding from React wrappers mentioned in the above issue:

Looks like a bug because Lit implementation doesn't care about nullability of notification

Type of change

  • Bugfix

@sonarqubecloud

sonarqubecloud Bot commented Nov 4, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @web-padawan , this commit cannot be picked to 23.1 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick 59dab62
error: could not apply 59dab62... fix: make notification renderer argument required (#4934)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

web-padawan added a commit that referenced this pull request Nov 4, 2022
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
web-padawan added a commit that referenced this pull request Nov 4, 2022
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants