Skip to content

refactor: update login overlay to not use dom-module - #4946

Merged
web-padawan merged 2 commits into
masterfrom
refactor/login-overlay-wrapper-cleanup
Nov 8, 2022
Merged

web-padawan merged 2 commits into
masterfrom
refactor/login-overlay-wrapper-cleanup

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Updated vaadin-lofin-overlay-wrapper to remove usage of dom-module which isn't needed.
Changed to use registerStyles for CSS and the html tag for template, as we do e.g. here:

const footerTemplate = html`
<div part="cancel-button">
<slot name="cancel-button"></slot>
</div>
<div part="reject-button">
<slot name="reject-button"></slot>
</div>
<div part="confirm-button">
<slot name="confirm-button"></slot>
</div>
`;

const footerTemplate = html`
<slot name="save-button"></slot>
<slot name="cancel-button"></slot>
<slot name="delete-button"></slot>
`;

Type of change

  • Refactor

@web-padawan
web-padawan requested a review from vursen November 7, 2022 12:10
@web-padawan

web-padawan commented Nov 7, 2022 •

Copy link
Copy Markdown
Member Author

UPD: failed screenshots are because of an issue with moduleId incorrectly using vaadin- prefix in Material.

@sonarqubecloud

sonarqubecloud Bot commented Nov 7, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
web-padawan removed the request for review from vursen November 8, 2022 07:35
@web-padawan
web-padawan merged commit 5e7d927 into master Nov 8, 2022
@web-padawan
web-padawan deleted the refactor/login-overlay-wrapper-cleanup branch November 8, 2022 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants