Repository navigation
refactor!: move default vaadin-crud-grid to light DOM - #4948
Conversation
4698bf8 to
e5ba39e
Compare
| vaadin-text-field[theme~='small'] { | ||
| height: 24px; | ||
| font-size: var(--material-small-font-size); | ||
| margin: 0; | ||
| padding: 0; | ||
| } |
There was a problem hiding this comment.
These styles don't work anymore, and can't be preserved due to ::slotted() limitations.
Adding registerStyles for other component, e.g. vaadin-grid-filter here isn't an option, because there is a chance that this component would be imported elsewhere, so a warning would be shown.
I'd say we can just remove this CSS completely, as Material theme is not our main priority.
Also, Flow counterpart is not using these styles because it always creates a slotted grid.
|
Converting the PR back to draft, please check out #4955 first, then I will rebase to also use controller for grid. |
e5ba39e to
7c2fc28
Compare
7c2fc28 to
410600d
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
| if (theme) { | ||
| grid.setAttribute('theme', theme); | ||
| } else { | ||
| grid.removeAttribute('theme'); | ||
| } |
There was a problem hiding this comment.
It looks like the theme was not propagated to the slotted grid before? I think it makes sense to propagate it, but want to make sure I'm getting this right.
There was a problem hiding this comment.
Yes, sounds like it wasn't. I could create a separate PR for 23.3 branch to fix that.
There was a problem hiding this comment.
UPD: actually, we have ITs in Flow counterpart to ensure theme is not propagated. Created #4999 to fix.
|
This ticket/PR has been released with Vaadin 24.0.0. |








Description
Fixes #4294
Moved the default
vaadin-crud-gridto light DOM ofvaadin-crudto align with the way how Flow counterpart works.This makes it possible to style
vaadin-crud-editelement andvaadin-text-fieldelements in header cells directly.Type of change