Skip to content

refactor!: restructure SlotController constructor arguments - #4954

Merged
web-padawan merged 2 commits into
masterfrom
refactor/slot-controller-tag-name
Nov 8, 2022
Merged

web-padawan merged 2 commits into
masterfrom
refactor/slot-controller-tag-name

Conversation

@web-padawan

@web-padawan web-padawan commented Nov 8, 2022 •

Copy link
Copy Markdown
Member

Description

This is a yet another breaking change intended to make usage of SlotController slightly less verbose.

  1. Replaced the slotFactory function with tagName string to specify which element to create.
  2. Moved remaining arguments slotInitializer and useUniqueId to a single config object.

Type of change

  • Breaking change

@web-padawan
web-padawan force-pushed the refactor/slot-controller-tag-name branch from 9991e1d to fb2e65b Compare November 8, 2022 12:36
@web-padawan web-padawan changed the title refactor!: replace SlotController factory with tag name refactor!: restructure SlotController constructor arguments Nov 8, 2022
@web-padawan
web-padawan marked this pull request as ready for review November 8, 2022 12:37
@web-padawan
web-padawan requested a review from vursen November 8, 2022 12:38
@sonarqubecloud

sonarqubecloud Bot commented Nov 8, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
web-padawan merged commit 8859d7c into master Nov 8, 2022
@web-padawan
web-padawan deleted the refactor/slot-controller-tag-name branch November 8, 2022 14:11
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants