Skip to content

feat: add option to disable observing slot changes - #4972

Merged
web-padawan merged 1 commit into
masterfrom
refactor/slot-controller-observe
Nov 10, 2022
Merged

web-padawan merged 1 commit into
masterfrom
refactor/slot-controller-observe

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Updated SlotController config, added an option to opt-out from observing slot changes.

This would be useful for components where slotted content is not supposed to change.
For example, vaadin-date-picker-overlay-content with its scrollers and buttons.

Type of change

  • Internal feature

@sonarqubecloud

sonarqubecloud Bot commented Nov 9, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
web-padawan removed the request for review from sissbruecker November 10, 2022 10:42
@web-padawan
web-padawan merged commit d86b90e into master Nov 10, 2022
@web-padawan
web-padawan deleted the refactor/slot-controller-observe branch November 10, 2022 10:42
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants