Skip to content

feat: add missing PositionMixin type definitions - #5042

Merged
web-padawan merged 1 commit into
masterfrom
feat/position-mixin-types
Nov 16, 2022
Merged

web-padawan merged 1 commit into
masterfrom
feat/position-mixin-types

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Anyone who wants to extend vaadin-overlay and use TS will likely encounter a problem with missing typings.
Now when this mixin is no longer experimental, let's consider adding type definitions to make it work in TS.

Type of change

  • Feature


customElements.define('custom-overlay', CustomOverlay);

const customOverlay = new CustomOverlay();

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using new instead of document.createElement as the latter would also require declare global ... stuff.

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
web-padawan removed the request for review from vursen November 16, 2022 14:33
@web-padawan
web-padawan merged commit 34e9db1 into master Nov 16, 2022
@web-padawan
web-padawan deleted the feat/position-mixin-types branch November 16, 2022 14:33
web-padawan added a commit that referenced this pull request Nov 16, 2022
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.0.0.alpha5 and is also targeting the upcoming stable 24.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants