Repository navigation
feat: add missing PositionMixin type definitions - #5042
Merged
Merged
Conversation
web-padawan
commented
Nov 16, 2022
|
|
||
| customElements.define('custom-overlay', CustomOverlay); | ||
|
|
||
| const customOverlay = new CustomOverlay(); |
Member
Author
There was a problem hiding this comment.
Using new instead of document.createElement as the latter would also require declare global ... stuff.
|
Kudos, SonarCloud Quality Gate passed!
|
tomivirkki
approved these changes
Nov 16, 2022
vaadin-bot
pushed a commit
that referenced
this pull request
Nov 16, 2022
web-padawan
added a commit
that referenced
this pull request
Nov 16, 2022
Collaborator
|
This ticket/PR has been released with Vaadin 24.0.0.alpha5 and is also targeting the upcoming stable 24.0.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
Anyone who wants to extend
vaadin-overlayand use TS will likely encounter a problem with missing typings.Now when this mixin is no longer experimental, let's consider adding type definitions to make it work in TS.
Type of change