Repository navigation
refactor: use helper function to iterate DOM children - #5059
Merged
Merged
Conversation
web-padawan
commented
Nov 21, 2022
Comment on lines
-374
to
-378
| Array.from(this.$.items.children) | ||
| .filter((row) => !row.hidden) | ||
| .forEach((row) => { |
Member
Author
There was a problem hiding this comment.
Changed the code here and elsewhere to use forEach and if instead of filter() + forEach().
web-padawan
force-pushed
the
refactor/iterate-children
branch
3 times, most recently
from
November 21, 2022 12:06
4d65c2b to
5b1a722
Compare
web-padawan
force-pushed
the
refactor/iterate-children
branch
from
November 22, 2022 09:35
5b1a722 to
7bcf40d
Compare
web-padawan
marked this pull request as ready for review
November 22, 2022 09:35
Member
|
Found one more occurrence here: |
Member
Author
Thanks, updated. |
sissbruecker
approved these changes
Nov 22, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
Collaborator
|
This ticket/PR has been released with Vaadin 24.0.0.alpha5 and is also targeting the upcoming stable 24.0.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
While working on #5020, I noticed that we use
Array.from(row.children)and[...row.children]in grid quite a lot.Created a small helper function to make the code a bit cleaner and updated a couple of occurrences to use it.
Type of change