Skip to content

fix: update parts when toggling column visibility - #5068

Merged
web-padawan merged 5 commits into
masterfrom
fix/update-row-order-parts
Nov 23, 2022
Merged

web-padawan merged 5 commits into
masterfrom
fix/update-row-order-parts

Conversation

@web-padawan

@web-padawan web-padawan commented Nov 22, 2022 •

Copy link
Copy Markdown
Member

Description

While working on #5067, I found an issue: some cell parts are reset when setting hidden on the column element.
In particular, the following part names related to various row states are currently affected by this problem:

  • first-row-cell
  • even-row-cell
  • last-row-cell
  • odd-row-cell
  • drag-disabled-row-cell
  • drop-disabled-row-cell
  • selected-row-cell
  • expanded-row-cell
  • details-opened-row-cell

Previously, this wasn't a problem as <tr> element is always there. Now we need to also update <td> elements.

Type of change

  • Bugfix

Comment thread packages/grid/src/vaadin-grid.js Resolved
@web-padawan
web-padawan force-pushed the fix/update-row-order-parts branch from b19e6a7 to f9d89bc Compare November 23, 2022 08:11
Comment thread packages/grid/test/basic.test.js Resolved
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.0.0.alpha5 and is also targeting the upcoming stable 24.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants