Repository navigation
fix: update parts when toggling column visibility - #5068
Merged
Merged
Conversation
web-padawan
force-pushed
the
fix/update-row-order-parts
branch
from
November 22, 2022 17:57
1a27683 to
0ec359e
Compare
tomivirkki
reviewed
Nov 23, 2022
web-padawan
force-pushed
the
fix/update-row-order-parts
branch
from
November 23, 2022 08:11
b19e6a7 to
f9d89bc
Compare
tomivirkki
reviewed
Nov 23, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
tomivirkki
approved these changes
Nov 23, 2022
Collaborator
|
This ticket/PR has been released with Vaadin 24.0.0.alpha5 and is also targeting the upcoming stable 24.0.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
While working on #5067, I found an issue: some cell parts are reset when setting
hiddenon the column element.In particular, the following part names related to various row states are currently affected by this problem:
first-row-celleven-row-celllast-row-cellodd-row-celldrag-disabled-row-celldrop-disabled-row-cellselected-row-cellexpanded-row-celldetails-opened-row-cellPreviously, this wasn't a problem as
<tr>element is always there. Now we need to also update<td>elements.Type of change