Skip to content

fix: ignore empty text nodes passed to default slot - #5072

Merged
web-padawan merged 2 commits into
masterfrom
fix/default-slot-controller
Nov 23, 2022
Merged

web-padawan merged 2 commits into
masterfrom
fix/default-slot-controller

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Fixed an issue with empty text nodes causing an element to be removed from the default slot.
This is currently the case with vaadin-grid-filter, see internal Slack thread.

Type of change

  • Bugfix

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.0.0.alpha5 and is also targeting the upcoming stable 24.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants