Skip to content

fix: use correct selectors in step buttons visible styles - #5140

Merged
web-padawan merged 1 commit into
masterfrom
fix/number-field-css
Dec 21, 2022
Merged

web-padawan merged 1 commit into
masterfrom
fix/number-field-css

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Fixes #5139

We missed to catch the issue with renaming the property to stepButtonsVisible because of incorrect visual tests 😞
This PR fixes it for Vaadin 24. When backporting to 23.3 we'll need both has-controls and step-buttons-visible.

Type of change

  • Bugfix

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.0.0.alpha7 and is also targeting the upcoming stable 24.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Number field with step buttons visible has text misaligned

3 participants