Repository navigation
refactor!: move DelegateStateMixin to component-base - #5180
Merged
Merged
Conversation
web-padawan
commented
Dec 28, 2022
| import { ControllerMixin } from '../src/controller-mixin.js'; | ||
| import { PolylitMixin } from '../src/polylit-mixin.js'; | ||
|
|
||
| export const define = { |
Member
Author
There was a problem hiding this comment.
This helper was missing from @vaadin/component-base - let's add it for testing mixins with Lit.
web-padawan
force-pushed
the
refactor/delegate-state-mixin
branch
from
December 28, 2022 15:51
893facd to
6f50fea
Compare
web-padawan
force-pushed
the
refactor/delegate-state-mixin
branch
from
December 28, 2022 18:01
6f50fea to
25af653
Compare
web-padawan
marked this pull request as ready for review
December 28, 2022 18:01
|
Kudos, SonarCloud Quality Gate passed!
|
vursen
approved these changes
Dec 29, 2022
Collaborator
|
This ticket/PR has been released with Vaadin 24.0.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
Depends on #5179 (created on top of it, to avoid merge conflicts).
Moved
DelegateStateMixintocomponent-baseas it's used by non-field components:vaadin-accordionvaadin-detailsvaadin-tabsheetThis allows to get rid of
@vaadin/field-basefor these components (at least forvaadin-tabsheet).Will also submit a similar PR for
DelegateFocusMixinwhich is used byvaadin-detailsinternally.Type of change