Skip to content

refactor!: move DelegateStateMixin to component-base - #5180

Merged
web-padawan merged 1 commit into
masterfrom
refactor/delegate-state-mixin
Dec 29, 2022
Merged

web-padawan merged 1 commit into
masterfrom
refactor/delegate-state-mixin

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Depends on #5179 (created on top of it, to avoid merge conflicts).

Moved DelegateStateMixin to component-base as it's used by non-field components:

  • vaadin-accordion
  • vaadin-details
  • vaadin-tabsheet

This allows to get rid of @vaadin/field-base for these components (at least for vaadin-tabsheet).
Will also submit a similar PR for DelegateFocusMixin which is used by vaadin-details internally.

Type of change

  • Internal breaking change

import { ControllerMixin } from '../src/controller-mixin.js';
import { PolylitMixin } from '../src/polylit-mixin.js';

export const define = {

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This helper was missing from @vaadin/component-base - let's add it for testing mixins with Lit.

@web-padawan
web-padawan force-pushed the refactor/delegate-state-mixin branch from 6f50fea to 25af653 Compare December 28, 2022 18:01
@web-padawan
web-padawan marked this pull request as ready for review December 28, 2022 18:01
@web-padawan
web-padawan requested a review from vursen December 28, 2022 18:01
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
web-padawan merged commit 8dbfb1f into master Dec 29, 2022
@web-padawan
web-padawan deleted the refactor/delegate-state-mixin branch December 29, 2022 07:40
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants