Skip to content

test: update visual test screenshots for Lumo button - #5275

Merged
web-padawan merged 1 commit into
masterfrom
test/button-screenshots
Jan 10, 2023
Merged

web-padawan merged 1 commit into
masterfrom
test/button-screenshots

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Follow-up to #5253

Some screenshots were not updated properly, including vaadin-button which caused #5267 to fail:

packages/button/test/visual/lumo/button.test.js:

 ❌ button > icons > prefix and text > default
      Error: Visual diff failed. New screenshot is 1.72% different.
      See diff for details: /home/runner/work/web-components/web-components/packages/button/test/visual/lumo/screenshots/button/failed/icon-prefix-small-diff.png
        at async o.<anonymous> (packages/button/test/visual/lumo/button.test.js:176:9)

 ❌ button > icons > suffix and text > default
      Error: Visual diff failed. New screenshot is 1.72% different.
      See diff for details: /home/runner/work/web-components/web-components/packages/button/test/visual/lumo/screenshots/button/failed/icon-suffix-small-diff.png
        at async o.<anonymous> (packages/button/test/visual/lumo/button.test.js:201:9)

Updated the screenshots for vaadin-button to make sure they don't fail the build.

Type of change

  • Tests

@web-padawan
web-padawan force-pushed the test/button-screenshots branch from 5526ddb to 27b3a2b Compare January 10, 2023 11:23
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.0.0.alpha9 and is also targeting the upcoming stable 24.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants