Skip to content

test: remove form-layout from upload visual tests - #5279

Merged
web-padawan merged 1 commit into
masterfrom
test/upload-width
Jan 10, 2023
Merged

web-padawan merged 1 commit into
masterfrom
test/upload-width

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Follow-up to #5253

After upgrading Chrome version to 108, the following visual test became flaky:

packages/upload/test/visual/lumo/upload.test.js:

 ❌ upload > form-item > form-item
      Error: Visual diff failed. New screenshot is 0.27% different.
      See diff for details: /home/runner/work/web-components/web-components/packages/upload/test/visual/lumo/screenshots/upload/failed/form-item-diff.png
        at async o.<anonymous> (packages/upload/test/visual/lumo/upload.test.js:144:7)

This visual test was added in #2907 while adding box-sizing: border-box rule.
IMO using vaadin-form-item to test this was an overkill, so I changed tests.

If you remove this line from vaadin-upload core styles, the new test fails:

box-sizing: border-box;

❌ upload > width > width
      Error: Visual diff failed. New screenshot is 0.11% different.

Type of change

  • Tests

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.0.0.alpha9 and is also targeting the upcoming stable 24.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants