Repository navigation
test: remove form-layout from upload visual tests - #5279
Merged
Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
tomivirkki
approved these changes
Jan 10, 2023
Collaborator
|
This ticket/PR has been released with Vaadin 24.0.0.alpha9 and is also targeting the upcoming stable 24.0.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
Follow-up to #5253
After upgrading Chrome version to 108, the following visual test became flaky:
This visual test was added in #2907 while adding
box-sizing: border-boxrule.IMO using
vaadin-form-itemto test this was an overkill, so I changed tests.If you remove this line from
vaadin-uploadcore styles, the new test fails:web-components/packages/upload/src/vaadin-upload.js
Line 126 in aaa2522
Type of change