Skip to content

fix: check dialog readyness before accessing overlay - #5285

Merged
web-padawan merged 1 commit into
masterfrom
fix/dialog-request-content-update
Jan 11, 2023
Merged

web-padawan merged 1 commit into
masterfrom
fix/dialog-request-content-update

Conversation

@tomivirkki

Copy link
Copy Markdown
Member

Description

<vaadin-dialog> currently throws when requestContentUpdate() is called before the element is fully initialized.

Type of change

  • Bugfix

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
web-padawan merged commit b1d8fd1 into master Jan 11, 2023
@web-padawan
web-padawan deleted the fix/dialog-request-content-update branch January 11, 2023 13:23
web-padawan pushed a commit that referenced this pull request Jan 11, 2023
Co-authored-by: Tomi Virkki <tomivirkki@users.noreply.github.com>
web-padawan pushed a commit that referenced this pull request Jan 11, 2023
Co-authored-by: Tomi Virkki <tomivirkki@users.noreply.github.com>
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.0.0.alpha9 and is also targeting the upcoming stable 24.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants