Skip to content

test: update button unit tests, wait for fixture render - #5304

Merged
web-padawan merged 1 commit into
masterfrom
test/button-await
Jan 14, 2023
Merged

web-padawan merged 1 commit into
masterfrom
test/button-await

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

  • Updated vaadin-button unit tests to use button variable name instead of the element;
  • Added nextRender() for easier debugging and to reduce changes during Lit conversion;
  • Changed tests for keyboard events to use spy.firstCall for getting an event reference.

Type of change

  • Tests

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.0.0.alpha9 and is also targeting the upcoming stable 24.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants